search

intermine / InterMine-Data-Browser-Tool

InterMine Data Browser: a tool for exploring semi-homogeneous biological datasets
http://data-browser.apps.intermine.org/
Other
7 stars 33 forks source link

Fixed footer #60

Closed dmahajan980 closed 4 years ago

dmahajan980 commented 4 years ago

Fixes #56

footer1

footer2

AdrianBZG commented 4 years ago

Hi @dmahajan980 ,

The style should be changed in the CSS in the src directory instead of the serving directory (/public). Could you please make the change?

Thanks 😄

dmahajan980 commented 4 years ago

Whoops! Sorry for that @AdrianBZG . Will fix that and send the PR as soon as possible.

dmahajan980 commented 4 years ago

@AdrianBZG I have made the changes as said. Please review it and let me know if there's anything wrong.

AdrianBZG commented 4 years ago

Hi @dmahajan980 ,

It looks like now part of the app has lost the background color and it's now gray, see:

image

AdrianBZG commented 4 years ago

I also got Error: Cannot find module 'es6-promise' when trying to npm start afte npm install.

dmahajan980 commented 4 years ago

Sorry for having generated so many errors. Will fix all of them and send a new PR. Also, es6-promise has been added to dependencies in commit #59. I am not sure why that error is generated. I'll check it out

dmahajan980 commented 4 years ago

Hi @AdrianBZG

I have sent another PR #61 which fixes #56 considering everything discussed till now. I would request you to close this pull request and kindly review #61.

Also, we can add the public directory in .gitignore as since it's generated by Gulp and we don't really need to push it every time it gets changed. What would you suggest?

AdrianBZG commented 4 years ago

Closed as author requested, moving to #61