search

intermine / InterMine-Data-Browser-Tool

InterMine Data Browser: a tool for exploring semi-homogeneous biological datasets
http://data-browser.apps.intermine.org/
Other
7 stars 33 forks source link

[lint] eslint, prettier setup and respective scripts implemented. #87

Closed muskangupta-iitr closed 4 years ago

muskangupta-iitr commented 4 years ago

Description

Successfully setup eslint and prettier with respective plugins, configurations, ignorefiles and scripts.

Related issues and discussion

Fixes #84

@Nikhil-Vats Review!

AdrianBZG commented 4 years ago

Hi @muskangupta-iitr , it looks there are some conflicts in package.json, could solve those?

muskangupta-iitr commented 4 years ago

@AdrianBZG I have rebased the PR.

muskangupta-iitr commented 4 years ago

@AdrianBZG @Nikhil-Vats I have also added the eslint-config-prettier as discussed in the discord group.

muskangupta-iitr commented 4 years ago

@Nikhil-Vats @AdrianBZG Can you please review this?

AdrianBZG commented 4 years ago

Hi @muskangupta-iitr , as happens in PR100, when I run the dev environment I'm getting this error:

`[Browsersync] Watching files... events.js:183 throw er; // Unhandled 'error' event ^

Error: watch node_modules/minimist/test ENOSPC at _errnoException (util.js:1022:11) at FSWatcher.start (fs.js:1382:19) at Object.fs.watch (fs.js:1408:11) at createFsWatchInstance (/home/adrian.bazaga/Repos/InterMine-Data-Browser-Tool/node_modules/chokidar/lib/nodefs-handler.js:38:15) at setFsWatchListener (/home/adrian.bazaga/Repos/InterMine-Data-Browser-Tool/node_modules/chokidar/lib/nodefs-handler.js:81:15) at FSWatcher.NodeFsHandler._watchWithNodeFs (/home/adrian.bazaga/Repos/InterMine-Data-Browser-Tool/node_modules/chokidar/lib/nodefs-handler.js:233:14) at FSWatcher.NodeFsHandler._handleDir (/home/adrian.bazaga/Repos/InterMine-Data-Browser-Tool/node_modules/chokidar/lib/nodefs-handler.js:429:19) at FSWatcher. (/home/adrian.bazaga/Repos/InterMine-Data-Browser-Tool/node_modules/chokidar/lib/nodefs-handler.js:477:19) at FSWatcher. (/home/adrian.bazaga/Repos/InterMine-Data-Browser-Tool/node_modules/chokidar/lib/nodefs-handler.js:482:16) at FSReqWrap.oncomplete (fs.js:153:5) `

node version: 8.10.0 npm version: 3.5.2

muskangupta-iitr commented 4 years ago

@AdrianBZG ENOSPC error comes when there is no space in the device. It is working fine in my PC. Did I did anything wrong in the code? PS: @AdrianBZG https://stackoverflow.com/questions/22475849/node-js-what-is-enospc-error-and-how-to-solve Can you try it out after running this?

JM-Mendez commented 4 years ago

@muskangupta-iitr it looks like installing those extra packages added too many file handles to the gulp watch command. Try changing this line https://github.com/intermine/InterMine-Data-Browser-Tool/blob/cde544be9193f7b2a215852b08982bd1653e5e77/gulpfile.js#L195

To this (remove the wildcard) gulp.watch('./node_modules', gulp.series('clean:vendor', 'vendor'))

You may have to add the trailing /, I can't be sure without running the command, and I'm not by my computer at the moment.

Ensure that the expected packages are still properly updated, by running npm uninstall bootstrap, and then npm install bootstrap. If the page reloads and applies the changes, then it should be a valid fix

Nikhil-Vats commented 4 years ago

@muskangupta-iitr Thank you so much for working on this one. 🎉 It's a big one and hence can already be counted as a contribution (feel free to do so).

Please be aware - this is a great start! 🚀 💯 I've mentioned quite a few things to improve, but not because it's bad - just because I think we can make it even better.

muskangupta-iitr commented 4 years ago

@Nikhil-Vats Thanks for reviewing my contribution and suggesting changes to it. I am glad to know them as working on them would improve my learning. I am reading more about linting and the related stuff and will try to update the PR asap. Also, thanks for the appreciation, it really means a lot :)

muskangupta-iitr commented 4 years ago

@Nikhil-Vats @AdrianBZG I have updated the PR. Please have a look on it.