intermine / InterMine-Data-Browser-Tool

InterMine Data Browser: a tool for exploring semi-homogeneous biological datasets
http://data-browser.apps.intermine.org/
Other
7 stars 33 forks source link

Add scroll to top button to web page #92

Closed Emuohwo closed 4 years ago

Emuohwo commented 4 years ago

Description

Describe the changes made and why they were made. Added a container in footer.pug for the scroll to top button: this is the container where the scroll button is located. Added js code for the button to common.js: I want to button to trigger when a user scroll to a certain level downward I did the styling of the button in _global.scss: This is to give the button a good look

Related issues and discussion

90

Screenshots, if any

This is the look on small screen image On a bigger screen image

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

Emuohwo commented 4 years ago

@AdrianBZG @Nikhil-Vats Kindly review Pull Request for issue #90

Nikhil-Vats commented 4 years ago

Nice work @Emuohwo. Everything works as expected. 💯 👍 🎉

I think this class is not used anywhere and can be removed. I tried removing it and everything works just fine. @AdrianBZG what do you think?

One more thing, for smaller screens the button overlaps footer content - overlapping button at 30px

I think we can increase bottom to 40px and it will be better that way, see - bottom:40px-ss1

bottom:40px-ss2

AdrianBZG commented 4 years ago

Hi @Emuohwo ,

Nice work, if you could address the issue pointed by @Nikhil-Vats (increase bottom to 40px), we'd happy to accept this PR 😄

Emuohwo commented 4 years ago

@Nikhil-Vats and @AdrianBZG consider it done.

Emuohwo commented 4 years ago

@Nikhil-Vats and @AdrianBZG the scroll button still covered part of the footer content even after I have increase bottom to 40px image I now increase the bottom to 50px and added a media query of max-width: 600px and set it to 75px. here's what I got image

image Should I continue with your recommendation or I should use the 50px and media query. What do you advice?

Nikhil-Vats commented 4 years ago

@Emuohwo Nice work on the media query! 🎉 💯 Can you change the media-query from max-width:600px to max-width:785px, it would look better that way?

Emuohwo commented 4 years ago

@Nikhil-Vats I have increased the width to 785px for the media query.

Nikhil-Vats commented 4 years ago

@Emuohwo Good work! 💯