intermine / InterMine-Data-Browser-Tool

InterMine Data Browser: a tool for exploring semi-homogeneous biological datasets
http://data-browser.apps.intermine.org/
Other
7 stars 33 forks source link

The X button is not clearing the input text when the user click on #94

Open shaymaa91 opened 4 years ago

shaymaa91 commented 4 years ago

@AdrianBZG @Nikhil-Vats
when the user use one of the filters (e.g: Pathway Name filter) and select one of the filter options, the X button is shown, and if the user click the button, it will reset the view and the table content, but the value of the input text is not cleared, I think since the view is cleared on the button press, then the input text value should be cleared also.

Steps to Reproduce

  1. use one of the filters, e.g: Pathway Name or Diseases filter, and choose one value from the list.
  2. once you choose a value, the X button will appear on the input field
  3. once you clicked the x button, the view will be reset without clearing the field value

Expected Behaviour

I think after the above steps, the filed should also be cleared once the user press the x button

Actual Behaviour

the value of the input field is not clearing when the user press the x button

Screenshots

after click x btn before click x btn

shaymaa91 commented 4 years ago

Hi @AdrianBZG @yochannah @Nikhil-Vats I have created this issue, could you please assign this issue to me if you see this should be fixed

shaymaa91 commented 4 years ago

@AdrianBZG I just sent a PR could you please review and let me know if every thing is good?