search

intermine / InterMine-Data-Browser-Tool

InterMine Data Browser: a tool for exploring semi-homogeneous biological datasets
http://data-browser.apps.intermine.org/
Other
7 stars 33 forks source link

[add]: autoFocus option added in autocompleted widget #95

Closed muskangupta-iitr closed 4 years ago

muskangupta-iitr commented 4 years ago

Description

When user types anything in the sidebar filters input boxes, user have to select one of the dropdown results in order to search for it. It doesn't work when user press the enter key.

Fixes #49

Solution

We can fix this issue by just enabling one of the options autoFocus:true as per the autocomplete documentation. As the user types anything in the input box, according to search results it will automatically selects the first option and when user press the enter it will be selected.

Nikhil-Vats commented 4 years ago

This doesn't work as expected. Please read this comment. Your PR prevents the user from writing free text and instead autocompletes the suggestion from the list of available filters, sometimes even with 3 letters, ex - I just wrote dat and it autocompleted to Antigen processing: Ubiquitination & Proteasome degradation, similarly just writing sig changes to Signal Transduction. Feel free to ask any doubts that you may have. 😃

@AdrianBZG Please correct me if I'm wrong. 😄

AdrianBZG commented 4 years ago

Hi @Nikhil-Vats , @muskangupta-iitr ,

Yes you are correct, the autocompletion should only be triggered when the user press the "enter" key, which should do two things:

  1. Autocomplete with the most likely term and
  2. Apply the filter
muskangupta-iitr commented 4 years ago

@AdrianBZG @Nikhil-Vats I will try to implement that and update the PR! Thanks :+1: