search

intermine / bluegenes-go-term-visualizer

MIT License
1 stars 7 forks source link

Centralize the rootContainer and Worked on the FIlter Panel #19

Closed egbobright closed 4 years ago

egbobright commented 4 years ago

Increased the width of the id yourDiv from 60% to 90%. This helped clear out the jumbled figures in the chart.

  1. Centralize the rootContainer by applying the margin-left property. This should make it more visible and accessible.
  2. Worked on the Filter Panel by: a. changing the background color and the text color. b. changing the Results length and c. applied border-radius accross all select and input tag.
heralden commented 4 years ago

This is a great start, but I'm not a fan of the new background colour and button hover colour (there's too much contrast compared to the rest of the elements).

I was also hoping to see a different layout of the filter panel. I think it can be made more compact, perhaps like this (I moved things around in gimp). Do you think you could work on this?

compact-filter-panel

egbobright commented 4 years ago

OK. I'll work on the Filter Panel again.

Thank you for the feedback.

On 23 Mar 2020 17:15, "Herald" notifications@github.com wrote:

This is a great start, but I'm not a fan of the new background colour and button hover colour (there's too much contrast compared to the rest of the elements).

I was also hoping to see a different layout of the filter panel. I think it can be made more compact, perhaps like this (I moved things around in gimp). Do you think you could work on this?

[image: compact-filter-panel] https://user-images.githubusercontent.com/3865590/77337697-275d5d80-6d21-11ea-89a3-23c37e6a8291.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/intermine/bluegenes-GO-term-visualizer/pull/19#issuecomment-602702595, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK3J2YKDYXKWKCNIEE2YYVLRI6DI7ANCNFSM4LRZKUPQ .

egbobright commented 4 years ago

Kindly check the improvement on the pull request I made earlier. I have reverted to the original background color but I worked on the display property in order to bring it close to gimp prototype.

egbobright commented 4 years ago

This is how it looks now: new_go_term

egbobright commented 4 years ago

Many thanks for your review. The change has been implemented on the rootContainer class.