search

intermine / bluegenes-protein-visualizer

MIT License
0 stars 6 forks source link

Fix demo.html and add CPK color assignments table to the visualizer #17

Closed bistaastha closed 4 years ago

bistaastha commented 4 years ago

Fixes #11

Fixes demo.html to point to HumanMine's URL in intermine-registry. Adds CPK coloring scheme based table on the bottom-right side of the visualizer.

bistaastha commented 4 years ago

The visualizer looks like this with the table: Screenshot from 2020-02-21 19-49-51

bistaastha commented 4 years ago

@uosl Thanks for letting me know :). I'll make the changes soon (probably tomorrow). The secondary structure in the visualiser seemed to have only the colors green and white, or was that only specific to the demo?

heralden commented 4 years ago

You're right. It seems like pv (the lib providing the protein viewer) has a different coloring scheme for secondary structure.

I think we should still move forward with this, as we're going to need it anyways, and hopefully #19 will be a suitable update in the future.

bistaastha commented 4 years ago

Hi @uosl! I made the required changes. There are now two tables - one for uniform coloring mode, another for coloring by secondary structure. They are conditionally used to render the table according to coloringMode passed to ColorTable.

Please let me know if this can be refined more. Thank you!

akshatbhargava123 commented 4 years ago

@uosl this looks good to me, let's go ahead and merge it.