search

intermine / bluegenes-protein-visualizer

MIT License
0 stars 6 forks source link

Change protein selector to a dropdown #2

Closed AdrianBZG closed 5 years ago

AdrianBZG commented 5 years ago

Sometimes, when the gene has a lot of proteins, the height of the protein visualizer is too big in BlueGenes. It would be better to have a dropdown to select the protein and a text over it saying something like "Choose a protein to be visualized".

AdrianBZG commented 5 years ago

Screenshot of what happens (Gene: KRAS):

image

yochannah commented 5 years ago

what about a typeahead + dropdown, maybe? best of both worlds - you can look for your preferred one or select it from a list

On Tue, 2 Jul 2019 at 12:03, Adrián Bazaga notifications@github.com wrote:

Sometimes, when the gene has a lot of proteins, the height of the protein visualizer is too big in BlueGenes. It would be better to have a dropdown to select the protein and a text over it saying something like "Choose a protein to be visualized".

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/intermine/bluegenes-protein-visualizer/issues/2?email_source=notifications&email_token=ACGXRDRYCJVEENEGSTCEPSDP5MYY7A5CNFSM4H42TN32YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G43KNTA, or mute the thread https://github.com/notifications/unsubscribe-auth/ACGXRDQUWLMAHIHFQ32CMW3P5MYY7ANCNFSM4H42TN3Q .

AdrianBZG commented 5 years ago

Sounds good!

akshatbhargava123 commented 5 years ago

@yochannah just to confirm - by typeahead you mean input with search and results in dropdown?

yochannah commented 5 years ago

Something like this: https://twitter.github.io/typeahead.js/examples/#default-suggestions (doesn't have to be the same library though if another is better)

On Tue, 2 Jul 2019 at 14:50, Akshat notifications@github.com wrote:

@yochannah https://github.com/yochannah just to confirm - by typeahead you mean input with search and results in dropdown?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/intermine/bluegenes-protein-visualizer/issues/2?email_source=notifications&email_token=ACGXRDQHGFEV2PU7SMH2RBLP5NMKFA5CNFSM4H42TN32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZBKYFA#issuecomment-507685908, or mute the thread https://github.com/notifications/unsubscribe-auth/ACGXRDTQN6IKGL7VRIYZS7DP5NMKFANCNFSM4H42TN3Q .

akshatbhargava123 commented 5 years ago

Resolved, thanks for this awesome enhancement idea.