intermine / bluegenes-protein-visualizer

MIT License
0 stars 6 forks source link

support tool API version 2 #22

Closed Sakshisrivastava413 closed 4 years ago

AdrianBZG commented 4 years ago

Hi @Sakshisrivastava413 !

Many thanks for upgrading the tool for API version 2.

I can see that your changes were intended to make the viz work when visiting a Gene page, but I think that it won't work when visiting a single Protein page as was before. You can see that this was handled here: https://github.com/intermine/bluegenes-protein-visualizer/blob/master/src/RootContainer.js#L60.

You can see that since now the viz is getting imEntity.Gene, I think it won't work as it will try to find Gene and Protein keys inside it (imEntity.Gene.Gene or imEntity.Gene.Protein). I may be wrong but I'm going to check in a moment.

Thanks.