intermine / bluegenes

A friendly next-generation interface for Genomic data discovery powered by InterMine
http://bluegenes.apps.intermine.org
Other
76 stars 56 forks source link

List results page is being inconsistent #218

Closed yochannah closed 6 years ago

yochannah commented 6 years ago

Reported by @kkarra:

The list you think you see may not be the list it thinks it is. See screenshot below:

image

yochannah commented 6 years ago

Strong suspicion: This may be to do with slow-loading results returning and being associated with the wrong, newer query.

yochannah commented 6 years ago

This is definitely due to slower network connections - which is why it's always worked fine for us, with beta flymine being in the same building :confounded:, but also why it was easy for Kalpana to notice give she's further away so won't get snappy speeds like we do...

To reproduce:

  1. set network throttling in chrome (the slow 3g setting definitely works, but I think fast 3g will too and might be less agonizing): https://developers.google.com/web/tools/chrome-devtools/network-performance/network-conditions
  2. Make multiple visits to the list results page with different lists and watch the weirdness happen.
joshkh commented 6 years ago

Great detective work. I'll make sure that pending query requests are cancelled when a new one is made.

yochannah commented 6 years ago

Fixed by https://github.com/intermine/bluegenes/pull/226