some pages (e.g. templates, idresolver) live in the components folder, while others live in the sections folder. It's a bit of a guess as to what lives where!
Shall we disambiguate? I propose the following strategy:
rename the "sections" to "pages". It then becomes pretty clear that any top-level page should have a folder here. This would include idresolver, my-data, region search, templates, search, etc.
any sub components that are re-usable in multiple pages should go in the components folder. This would include components/ui, components/navbar, etc.
sub components that are only on one page and likely to remain so should be within their parent folder. This would include components/enrichment (move to the /results folder).
Furthermore, we briefly decided and then un-decided to keep all events in an /src/cljs/bluegenes/events folder rather than individual component folder, and the same for subscriptions. We didn't actually do this for long before deciding not to do it, though - and we should probably migrate all the files out of these two folders and in to the right places, instead.
yochannah
commented
5 years ago
ok, we have legacy folder structure from a few different refactors. Consider the following folders
/src/cljs/bluegenes/components/src/cljs/bluegenes/sectionssome pages (e.g. templates, idresolver) live in the components folder, while others live in the sections folder. It's a bit of a guess as to what lives where!
Shall we disambiguate? I propose the following strategy:
Furthermore, we briefly decided and then un-decided to keep all events in an
/src/cljs/bluegenes/eventsfolder rather than individual component folder, and the same for subscriptions. We didn't actually do this for long before deciding not to do it, though - and we should probably migrate all the files out of these two folders and in to the right places, instead.