search

intermine / bluegenes

A friendly next-generation interface for Genomic data discovery powered by InterMine
http://bluegenes.apps.intermine.org
Other
76 stars 56 forks source link

Remove re-frisk dev tool #353

Closed heralden closed 5 years ago

heralden commented 5 years ago

Since we've added re-frame-10x which has an app-db explorer, there seems to be no reason to include re-frisk anymore.

yochannah commented 5 years ago

nuke it! :D

yochannah commented 5 years ago

@uosl am I right in thinking one of your PRs already did this?

heralden commented 5 years ago

Nope! [=

One useful feature I've discovered with re-frisk however, is that since it's always enabled on dev, the application state will be browseable at any time. This isn't true for re-frame-10x, as it will only be enabled while the panel is open. So if you suddenly decide to explore app-db, but didn't open the panel when you started the web app, it won't be available in re-frame-10x unless you refresh, starting the state from scratch (or localstorage).

yochannah commented 5 years ago

okay - should we leave it in and close this issue, then?

On Mon, 24 Jun 2019 at 16:07, Herald notifications@github.com wrote:

Nope! [=

One useful feature I've discovered with re-frisk however, is that since it's always enabled on dev, the application state will be browseable at any time. This isn't true for re-frame-10x, as it will only be enabled while the panel is open. So if you suddenly decide to explore app-db, but didn't open the panel when you started the web app, it won't be available in re-frame-10x unless you refresh, starting the state from scratch (or localstorage).

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/intermine/bluegenes/issues/353?email_source=notifications&email_token=ACGXRDVWGPXIMT2FQJTVG5DP4DPLLA5CNFSM4HWUUJQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYNHTSA#issuecomment-505051592, or mute the thread https://github.com/notifications/unsubscribe-auth/ACGXRDSBRUP2YZBLX6VZZFTP4DPLLANCNFSM4HWUUJQA .

heralden commented 5 years ago

Yes. I found another useful feature: re-frisk stays alive when things crash and burn (uncaught error) while re-frame-10x's app-db explorer dies.

We'll keep re-frisk, and I'll close this issue.