intermine / bluegenes

A friendly next-generation interface for Genomic data discovery powered by InterMine
http://bluegenes.apps.intermine.org
Other
76 stars 56 forks source link

Make sure Bluegenes CSS does not affect tools #425

Open heralden opened 4 years ago

heralden commented 4 years ago

The Bluegenes Less CSS sources contain a lot of global selectors that end up changing the styling of visualisation tools.

Here is one example with https://github.com/intermine/bluegenes-protein-visualizer Top is how it looks in Bluegenes, bottom is how it's intended to look. (Pay attention to the text in the options panel to the right.)

2019-10-14-140619_938x543_scrot 2019-10-14-140637_857x544_scrot

yochannah commented 4 years ago

@uosl I think there's some argument for intentionally having the tools be affected by bluegenes - while they are developed in javascript, they're created with the intention of being used in bluegenes, and it provides a more seamless experience if everything is themed similarly - (consistency is an important part of usability). In theory, there shouldn't be any differences between the standalone app and the embedded bluegenes tool - see https://github.com/intermine/generator-bluegenes-tool/tree/master/generators/app/templates/css. We might need to update the embedded stylesheet in the tools and generator.

heralden commented 4 years ago

Ok. It's gonna be tricky if we have to commit the Bluegenes stylesheet to every tool repo whenever it changes. How about uploading it to a CDN, and referencing that in demo.html instead?

yochannah commented 4 years ago

that is a much more sustainable way of doing things! 👍

On Fri, 25 Oct 2019 at 12:15, Herald notifications@github.com wrote:

Ok. It's gonna be tricky if we have to commit the Bluegenes stylesheet to every tool repo whenever it changes. How about uploading it to a CDN, and referencing that in demo.html instead?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/intermine/bluegenes/issues/425?email_source=notifications&email_token=ACGXRDXVDSZGY5AFLBSH7DTQQLIMNA5CNFSM4JAO6I62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECIBE7Y#issuecomment-546312831, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACGXRDSV3ZRNS4UISFYDR3TQQLIMNANCNFSM4JAO6I6Q .