Open heralden opened 4 years ago
@uosl I think there's some argument for intentionally having the tools be affected by bluegenes - while they are developed in javascript, they're created with the intention of being used in bluegenes, and it provides a more seamless experience if everything is themed similarly - (consistency is an important part of usability). In theory, there shouldn't be any differences between the standalone app and the embedded bluegenes tool - see https://github.com/intermine/generator-bluegenes-tool/tree/master/generators/app/templates/css. We might need to update the embedded stylesheet in the tools and generator.
Ok. It's gonna be tricky if we have to commit the Bluegenes stylesheet to every tool repo whenever it changes. How about uploading it to a CDN, and referencing that in demo.html instead?
that is a much more sustainable way of doing things! 👍
On Fri, 25 Oct 2019 at 12:15, Herald notifications@github.com wrote:
Ok. It's gonna be tricky if we have to commit the Bluegenes stylesheet to every tool repo whenever it changes. How about uploading it to a CDN, and referencing that in demo.html instead?
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/intermine/bluegenes/issues/425?email_source=notifications&email_token=ACGXRDXVDSZGY5AFLBSH7DTQQLIMNA5CNFSM4JAO6I62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECIBE7Y#issuecomment-546312831, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACGXRDSV3ZRNS4UISFYDR3TQQLIMNANCNFSM4JAO6I6Q .
The Bluegenes Less CSS sources contain a lot of global selectors that end up changing the styling of visualisation tools.
Here is one example with https://github.com/intermine/bluegenes-protein-visualizer Top is how it looks in Bluegenes, bottom is how it's intended to look. (Pay attention to the text in the options panel to the right.)