search

intermine / generator-bluegenes-tool

Scaffold generator for BlueGenes tools
MIT License
5 stars 8 forks source link

Tool linter / validator? #17

Closed yochannah closed 4 years ago

yochannah commented 5 years ago

Or even just ESLint in the scaffolder?

heralden commented 5 years ago

Should this be in the https://github.com/intermine/generator-bluegenes-tool/ repo? I'm not sure how we can do this in bluegenes.

yochannah commented 5 years ago

yes!

On Wed, 31 Jul 2019 at 16:30, Herald notifications@github.com wrote:

Should this be in the https://github.com/intermine/generator-bluegenes-tool/ repo? I'm not sure how we can do this in bluegenes.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/intermine/bluegenes/issues/280?email_source=notifications&email_token=ACGXRDUSBCJ5MSASGE56M5DQCGVZRA5CNFSM4FXCHXP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3HULAQ#issuecomment-516900226, or mute the thread https://github.com/notifications/unsubscribe-auth/ACGXRDWSK2Z5JOBNMSDYE5DQCGVZRANCNFSM4FXCHXPQ .

heralden commented 4 years ago

Closing this as it was added in https://github.com/intermine/generator-bluegenes-tool/pull/7.

yochannah commented 4 years ago

@uosl this wasn't what I meant actually 😆 so much as a way of checking that a tool can successfully run in bluegenes - e.g. it takes an id or ids and produces results, provides the correct arguments so bluegenes knows what to do, etc. Sorry - it was clear in my brain but I can see why you would think it was referring to eslint!

yochannah commented 4 years ago

wait, this should be a separate issue. Ignore that.