search

intermine / im-tables

Dynamic Result Table Library
Other
9 stars 27 forks source link

Supporting SVG icons #215

Closed Manasa2850 closed 3 years ago

Manasa2850 commented 4 years ago

Fixes issue #168 The latest version of font awesome 5.12.1 supports SVG so I've updated the version from 4.7.0 to 5.12.1

heralden commented 3 years ago

I apologise for the very late feedback!

Thank you for looking into the issue.

I believe the intent of #168 was to use SVGs instead of the fontawesome font. Updating fontawesome won't be enough to achieve this; we'd need to include all of the SVG sources and reference them as specified here (in other words, a pretty substantial change). I am sorry for the confusion!

I will be closing this PR as I'm not expecting a response after this long time. You are welcome to open another PR if you wish to tackle this issue again.