search

intermine / im-tables

Dynamic Result Table Library
Other
9 stars 27 forks source link

Arbitrary page option doesn't work #227

Open Manasa2850 opened 4 years ago

Manasa2850 commented 4 years ago

WhatsApp Image 2020-03-31 at 7 38 34 PM

The desired result for this is we should click that button and enter any arbitrary number and then clicking enter will take us to that page. However it's not working that way. Entering a number and then clicking enter doesn't do anything.

Saffafatima12 commented 3 years ago

Just wanted to mention that I have found a solution for this. I will be making a PR soon :)

Saffafatima12 commented 3 years ago

Hi! Just wanted to mention that I made a pull request for this issue 4 days ago. It would be great if someone could review my PR and let me know if there are any errors that I need to correct Thank you! 🙂

heralden commented 3 years ago

Hello @Saffafatima12!

Thank you for the update. We have a bunch of PRs from earlier this year that haven't been addressed (I tried going through some of them today, but the merge conflicts due to dist files changing is really weighing me down).

This library is also for the old webapp, which will soon be replaced by Bluegenes (which has its own library under development: https://github.com/intermine/im-tables-3/). Hence, changes to this version of im-tables are not prioritized.

I will see if I can figure out some git magic to handle the merge conflicts and clean up the PRs in this repo. Until then I'm afraid reviewing your PR will be delayed.

Saffafatima12 commented 3 years ago

Thank you so much for the information @uosl. I apologize, I wasn't aware that this webapp was soon to be replaced. I will try learning about the code for im-tables-3. Thanks once again!

heralden commented 3 years ago

Don't worry about it, @Saffafatima12. It's our fault as we haven't written anywhere in the README about this. :sweat_smile:

I still think fixes and improvements to this im-tables is useful however, as it will still be in use for a while. :+1: