search

intermine / intermine-apps-c

InterMine apps built using Bower and Grunt
http://intermine-apps-c.labs.intermine.org/
1 stars 3 forks source link

component-400: interactions widget cuts off the rightmost column. #43

Open yochannah opened 4 years ago

yochannah commented 4 years ago

We've had an issue reported where the right-hand edge of cells are truncated in certain scenarios. I think this is to do with the long table headers on the leftmost cell.

See https://github.com/intermine/intermine/issues/2188 where this was originally reported. image - in this image the numbers on the right are cut off!

on my laptop on firefox it's even worse - the matches column doesn't even show up:

image

My suggestion - give the top left table header cell a maximum width.

This might be a css-only fix - we'll need to update this file: https://github.com/intermine/intermine-apps-c/blob/master/component-400/src/app.styl

sergiocontrino commented 4 years ago

please note also that the columns setting seems wasteful, and the header should probably have 'Identifier', 'Name' rather than the partial path.

dmahajan980 commented 4 years ago

@yochannah I would like to work on this issue if it isn't fixed yet.

yochannah commented 4 years ago

@dmahajan980 - I think @ankitskvmdam has probably solved this one (need to review it still) but thanks for the offer! ✨

dmahajan980 commented 4 years ago

@yochannah Cool! Let me know there's anything that I can help with.