intermine / intermine-apps-c

InterMine apps built using Bower and Grunt
http://intermine-apps-c.labs.intermine.org/
1 stars 3 forks source link

Google Charts API Moved; broke all list widgets, even the ones that didn't use charts. #57

Open yochannah opened 4 years ago

yochannah commented 4 years ago

We thought we had fixed https://github.com/intermine/intermine-apps-c/issues/45, but we had not.

There's a mix of a few things going on here:

  1. 🚚 Google moved the old jsapi script. The fix seems straightforward at face value - see https://developers.google.com/chart/interactive/docs/basic_load_libs#updateloader for the method signature update, and the updated url to point to the new script. This was completed in the fix for #45, and the up-to date script works fine so long as you're only using it locally, e.g. by serving a clone of this repo on your machine.
  2. πŸ’₯ When we deploy the "fixed" script onto InterMine something still fails. My guess is that there are a few things going on - we probably need to fix some places it's hardcoded into intermine, too, like these: https://github.com/intermine/intermine/search?q=jsapi&unscoped_q=jsapi ◀️ ◀️ ◀️ This is where the biggest problem still lies - I'm not sure what's going on. I thought maybe it was the minified version, or the bundled vs unbundled versions but I think I managed to rule that out, too. I would suggest double-checking both these avenues, though.
  3. πŸ’ The cherry on the top: when the google chart loading fails it kills all of the other widgets, such as enrichment, even though the enrichment widgets don't user the google charts api. Initialising the google widgets in a try/catch block would fix this, and make all the widgets a bit more robust.