search

intermine / intermine-homepage-2017

InterMine's new homepage as of 2017
http://intermine.org
GNU Lesser General Public License v2.1
5 stars 28 forks source link

ui changes #39

Closed roshnidesigns closed 4 years ago

roshnidesigns commented 4 years ago

37 done

https://tinycosmos.github.io/intermine-homepage-2017/

roshnidesigns commented 4 years ago

Thanks for making this PR, @tinycosmos ! A few comments:

  1. could you please add a screenshot and summarise your changes? We have a lot of whitespace change here so it's a little tricky to spot what code you tweaked.
  2. I can see that the style.css file has changed - this is partly my fault for insufficiently documenting this, but the style.css file shouldn't be editing directly. See https://github.com/intermine/intermine-homepage-2017/blob/master/static/style.less

Let me know when you've tweaked these aspects and I'll take another look! ✨

Screenshot (78) line 1-3

Screenshot (79) line 38, line 54 extra spaces must be my editor's work, sorry for that. so i have to do the same changes to style.less and style.css not to be edited at all?

yochannah commented 4 years ago

Sorry to be unclear 😅 @tinycosmos I meant screenshots of what the UI would look like after the changes - but the screenshots you've added here are helpful too!

roshnidesigns commented 4 years ago

Frame 1

extra block is removed which removes the unrequired extra space visible while minimizing the tab

also made the underlined colors same to maintain consistency

yochannah commented 4 years ago

@tinycosmos ahhhhhh, the screemshots have finally made me figure out what was going on! See https://github.com/intermine/intermine-homepage-2017/issues/37#issuecomment-605983339 - I'm going to close this PR for now but please count it as a contribution. You helped us discover a bug I didn't realise was there.