Use DisplayNames where possible

intermine / intermine-ios

Intermine iOS application - developed as part of GSoC 2017 by Nadia Yudina

2 stars 1 forks source link

Use DisplayNames where possible #4

Closed yochannah closed 7 years ago

yochannah commented 7 years ago

You can find display names in the model for each mine to make field names more human friendly - i.e. secondaryIdentifier becomes "Secondary Identifier"

nadia-dev commented 7 years ago

@yochannah, where can i find an instance of it in the app? is it for search results or templates/lists?

yochannah commented 7 years ago

Sorry, I should have been clearer! Places that are affected:

[ ] Search results (list)
[ ] Search results (individual result page)
[ ] Favourites

Lists seems ok and I can't check templates right now - I think I'm seeing a template result and I can't figure out how to get out of it (that'll be a separate bug lol)

nadia-dev commented 7 years ago

Ok. I added the issue for template result page

nadia-dev commented 7 years ago

@yochannah, i am not sure how we can fix it. I am using the result of the http request (for example, http://www.mousemine.org/mousemine/service/search?q=c2c&start=0&size=10&format=json&facet_Category=Gene), and it only contains primary identifier. For example, the response for the previous request is: "facets": { "Category": { "Gene": 1 }, "organism.shortName": { "M. musculus": 1 }, "pathways.name": {} }, "results": [{ "id": 12875412, "type": "Gene", "fields": { "symbol": "Scgb2b20", "sequenceOntologyTerm.name": "protein_coding_gene", "name": "secretoglobin, family 2B, member 20", "organism.name": "Mus musculus", "primaryIdentifier": "MGI:3514009" }, "relevance": 0.24681501 }], "executionTime": "2017.04.25 18:01::31", "wasSuccessful": true, "error": null, "statusCode": 200 }

yochannah commented 7 years ago

Whoops, I didn't mean specifically secondary identifier. I mean that in screens like this one, use display names rather than computer names in general - so for this screenshot:

"Molecular Weight" rather than "molecularWeight" "Type" rather than "type" "Primary Identifier" rather than "primaryIdentifier"

This info (converting from the computer names to the display names) can be gleaned from the model.

Does that make more sense?