search

intermine / intermine-ios

Intermine iOS application - developed as part of GSoC 2017 by Nadia Yudina
2 stars 1 forks source link

Templates - Obsolete constrains #69

Closed nadia-dev closed 7 years ago

nadia-dev commented 7 years ago

To filter out obsolete constraints, we may have to hard-code them. @yochannah, maybe some more comments, as i don't fully understand this...

yochannah commented 7 years ago

Specifically this was regarding the following suggestions from Gos regarding a template:

  • in YeastMine only certain constraints are visible to the end-user unless they click "Edit Query" and so this hides the Obsolete constraints - would it be possible to do likewise? i.e. in this case only have an input field for "GO Term Identifier"? I expect that the template ought to self-describe which fields/ constraints are visible and which are invisible.
  • If you were optionally to show all the constraints it would be nice to pick up the "Obsolete" as well as the "IS NULL" and "false".

I'm guessing the hidden obsolete constraint is specified via a config file somewhere, or possibly hard coded into the codebase, and probably not available via the web services. @julie-sullivan @kkarra is this correct?

nadia-dev commented 7 years ago

I used "editable" field of the constraint object to decide whether a constraint should be shown to the user of not. @yochannah, is this correct? If yes, we can do this feature in this iteration of the app - it is easy :)

yochannah commented 7 years ago

Hmm, I'm not sure but I will try to find out today!

rachellyne commented 7 years ago

Yes, i think that's correct - anything editable should be shown. Some constraints are fixed and therefore do not need to be shown.

yochannah commented 7 years ago

thanks @rachellyne !