intermine / intermine-registry

Registry to store and browse all known instances of InterMine. Developed during GSoC 2017 by Leonardo Kuffo
http://registry.intermine.org
GNU Lesser General Public License v2.1
7 stars 24 forks source link

Add namespace #116

Closed danielabutano closed 5 years ago

danielabutano commented 5 years ago

I have added a new field "namespace". Please test:

Please suggest :)

yochannah commented 5 years ago

@danielabutano I've checked the bits that add and update:

When I try to add a namespace (update an instance) or add a new instance, I'm getting a few errors - the update form is only half populated and the server process quits when I try to save an instance.

I think mostly we need to check for null values in certain places. The error is happening in a couple of different places, too. Would you mind if I refactored a little?

I still need to check the other bits of this PR so I may have more comments.

danielabutano commented 5 years ago

Thanks @yochannah. Please go ahead