intermine / intermine-registry

Registry to store and browse all known instances of InterMine. Developed during GSoC 2017 by Leonardo Kuffo
http://registry.intermine.org
GNU Lesser General Public License v2.1
7 stars 24 forks source link

new feature: return all intermines over version x #130

Open yochannah opened 5 years ago

yochannah commented 5 years ago

Sometimes applications need to fetch all InterMines, but only above (or below) a certain version, to avoid calling features that don't exist, or to take advantage of newer features. IT would be nice to ask the registry to only return InterMines of the version we want.

A useful API call to the registry might look something like this:

http://registry.intermine.org/service/instances?version_api=gte-25 http://registry.intermine.org/service/instances?version_api=lt-24 http://registry.intermine.org/service/instances?version_api=eq-24

http://registry.intermine.org/service/instances?version_intermine=gte-2.0.0 http://registry.intermine.org/service/instances?version_intermine=lt-1.6.6 http://registry.intermine.org/service/instances?version_intermine=eq-4.0.0

the operators I've suggested above are:


gt (greater than)
gte (greater than or equal to)
lt (less than)
lte (less than or equal to)
eq (equal to)

Additionally, note that there are several different version strings returned by InterMines. Visit http://iodocs.apps.intermine.org and look at flymine, then search for the version endpoint. Here's a quick summary:

GET /version returns the API version. This is a int. GET /version/release returns the version of the data release for that InterMine (and will be a string with arbitrary content) GET /version/intermine returns the version of InterMine (as in the Java application). This looks like a number but is a string in semantic versioning format, e.g. "4.0.0".

/version/release and /version/intermine are newer endpoints, and older InterMines, such as Indigo, won't respond to them correctly - they'll return the int response, same as /version does. See http://www.cbrc.kaust.edu.sa/indigo/service/version/intermine for an example. Checking the response data type will give you an hint about which InterMines this happens in.

FINAL note - we should probably sort on API version and InterMine version, but the release version endpoint, given that it's arbitrary string data, won't be sortable, so it wouldn't make sense to have a filter for it.

awasthishubh commented 4 years ago

I would like to take this. :) Few doubts/suggestions:

zrthxn commented 3 years ago

Hi there @yochannah If I have understood your description correctly, this can be done by filtering for the appropriate version for API and Intermine versions in this route. https://github.com/intermine/intermine-registry/blob/37f67f2ac7ab01119aefc95b5267aab96a3f267a/routes/instances.js#L22-L61 And the release date param can probably be ignored since, like you said, it's arbitrary string data and it doesn't make sense to sort by the release date? (or maybe not?)

I can try some solutions out and see what works best. I'll just need to know how to connect the registry to an existing database.

yochannah commented 3 years ago

hey @zrthxn - I've moved on from the InterMine team now. Paging @danielabutano or @uosl who I believe are still on the team and might be able to answer :)