search

intermine / intermine-ws-python

InterMine Client library in Python
http://www.intermine.org
BSD 2-Clause "Simplified" License
7 stars 34 forks source link

[easier issue if you know python] apply pep8 formatting to all files #59

Open yochannah opened 4 years ago

yochannah commented 4 years ago

We have pep8 speaks set up to check files that are edited in PRs - but we still have some files that aren't checked because they haven't been edited in a while.

Task: Apply pep8 formatting to all files in this repo. You probably want to try a command something like autopep8 . -r --in-place.

Note that this command might not fix all long lines - some might need to be done manually.

if you want to pick up this task

  1. Take a look at the InterMine contributing guidelines
  2. Comment on this issue stating that you intend to work on the task
  3. When you're ready, add your work to the repo and create a pull request.

What to do if you need help

Mention @yochannah, tweet @yoyehudi, pop by to say hi on chat or if needed email yo@intermine.org. Don't forget we're usually only available during uk office hours and will not be able to respond at other times :)

ayham-1 commented 4 years ago

Hi @yochannah ! I would like to take this.

yochannah commented 4 years ago

Awesome, go for it! 🚀

ooo[bot] commented 4 years ago

:wave: Hey @realaltffour...

Letting you know, @yochannah is currently OOO until Monday, October 28th 2019. :heart:

mbasil09 commented 4 years ago

@yochannah If no one is working on it I would like to do so. I was wondering if we could apply some external open source library like "coala-bears" to do this formatting. It would drastically reduce the effort.

yochannah commented 4 years ago

@mbasil09 I think (just waiting for the CI to pass) that https://github.com/intermine/intermine-ws-python/pull/62 probably has fixed the overal library formatting issue - BUT - you would be entirely welcome to implement coala-bears if you think it would make the pep8 formatting better! We have autopep8 at the minute, but it doesn't seem to quite catch everything straight away.