intermine / pombemine

0 stars 1 forks source link

conditions currently create separate annotations #62

Open ValWood opened 2 years ago

ValWood commented 2 years ago

Conditions are attached to a specific annotation as a "group", but currently each condition creates a separate annotation:

This causes a problem for querying.

here:

Screenshot 2022-06-06 at 14 51 22

If I filter on NOT standard temperature, I would still retain the phenotype annotation because the experiment was performed using YES media (even though the experiment was also performed at standard temperature, and so should be filtered )

@kimrutherford

kimrutherford commented 2 years ago

but currently each condition creates a separate annotation

That's what I'd expect if there is more than one condition.

ValWood commented 2 years ago

That will give slightly incorrect results in a query Probably only the queries where you contain on not having a particular condition. They should be a "subtable", they are like comma separated (compound) extensions, they all belong with a single annotation.

For example, if a gene is only enviable at high temperature, and you want to exclude those annotations from your query to find genes that are enviable only in standard temperature, the genes would still remain in the results from the other conditions still being present on independent annotations.