internalfx / quickshot

A Shopify theme development tool.
ISC License
107 stars 18 forks source link

Updates to Shopify theme editor causing additional downloads with --sync #80

Closed joshuaiz closed 2 years ago

joshuaiz commented 4 years ago

Hello,

It looks like Shopify updated the theme editor in the admin and the update seems to be causing issues with theme watch --sync.

When --sync is active and I save a file locally, QS is downloading the theme editor file which is overwriting local changes. I have to save a few times to get it to "stick". These files shouldn't be downloaded...I'm updating them locally and then saving - there is no processing e.g. with an scss.liquid or js.liquid file.

CleanShot 2020-10-08 at 16 37 02@2x

I just started noticing this today and then saw this message in the Shopify admin:

CleanShot 2020-10-08 at 16 37 52@2x

I'm going to contact Shopify Plus support but just wanted to see if anyone else is seeing this and if there's anything we can do to fix.

Thanks!

joshuaiz commented 4 years ago

Contacted Shopify Plus support and was able to opt out of the new Theme Editor. Quickshot is working as normal.

This may not be a viable solution long term if the Shopify editor is updated.

internalfx commented 2 years ago

@joshuaiz is this still an issue?

joshuaiz commented 2 years ago

No this was resolved. You can close.