international-labour-organization / designsystem

A design system for the International Labour Organization
Apache License 2.0
1 stars 3 forks source link

Develop photo gallery component #1011

Open inesdgomes opened 4 months ago

inesdgomes commented 4 months ago

We have some designs for a photo gallery component that were never developed. From a design point of view, we need to:

https://www.figma.com/design/RRxsfLNxjoypKrfJg1EwJf/ILO-Components-Library?node-id=233-9427&t=OQSWduYkjHB7OueD-0

@beatrizmartinmartins Could we aim for 22 May to have designs ready for development?

inesdgomes commented 4 months ago

FYI @justintemps Tagging you here so you know this is coming.

beatrizmartinmartins commented 3 months ago

@inesdgomes I made a component that could work. I will get into more details tomorrow https://www.figma.com/design/RRxsfLNxjoypKrfJg1EwJf/ILO-Components-Library?m=auto&node-id=3917-7227&t=JGGUJcgZCwrckaJV-1

inesdgomes commented 2 weeks ago

Hi @beatrizmartinmartins Just looking at this and I think the comments I left in Figma were not addressed. Can you take a look? Thanks

beatrizmartinmartins commented 2 weeks ago

Let's review this component tomorrow so I can explain in more detail the logic behind it

inesdgomes commented 6 days ago

@beatrizmartinmartins There are some comments to address in the Figma file from our latest conversation.

beatrizmartinmartins commented 5 days ago

@inesdgomes made the changes that we talked about and also made some more adjustments needed.

inesdgomes commented 6 hours ago

Thanks @beatrizmartinmartins Before we share this with Justin and the other developers, could the designs be made clearer about the different states, options and breakpoints? It's not entirely clear by just looking at the designs whether there are different options for the same scenario, or whether they're all part of the same scenario for the component.

beatrizmartinmartins commented 56 minutes ago

@inesdgomes I have included the labels with the different variants that we have on the component. Is this be enough?