Promo card: narrow size needs a different heading style

international-labour-organization / designsystem

A design system for the International Labour Organization

Apache License 2.0

1 stars 3 forks source link

Promo card: narrow size needs a different heading style #1020

Open inesdgomes opened 1 month ago

inesdgomes commented 1 month ago

When the graphic promo is used with a 'narrow' size, the style of the heading should change from H2 to H3.

Example here: https://iloorgstg.prod.acquia-sites.com/resource/article/test-page

justintemps commented 1 month ago

Hey @inesdgomes, as agreed, the card takes a parameter that allows a developer to set the heading level. I don't think we should implement this in the DS, it belongs with users.

inesdgomes commented 1 month ago

@justintemps As mentioned in the title and in the description, the heading style needs to be different, even if we don't set the headings levels in DS. What I mean is that the font needs to be aligned with the properties defined for H3. If the card is narrower, the font needs to be smaller.

inesdgomes commented 1 month ago

@justintemps Here's why this is needed: https://www.ilo.org/resource/news/asia-pacific-labour-markets-show-recovery-amidst-looming-demographic