search

international-labour-organization / designsystem

A design system for the International Labour Organization
Apache License 2.0
1 stars 3 forks source link

Add search option to sub-site nav #1206

Open inesdgomes opened 3 weeks ago

inesdgomes commented 3 weeks ago

The sub-site nav does not currently support search. @beatrizmartinmartins Could you please review the component in order to integrate the search button? See here the use case for this: https://www.figma.com/design/ulu2zb7ZOuT4VXu4M7Yp98?node-id=4-3061#940888322

justintemps commented 3 weeks ago

@inesdgomes and @beatrizmartinmartins just to add that for the time being, I think it should just be a link to a search page. Must subsites don't need their own keyword search.

beatrizmartinmartins commented 2 weeks ago

@justintemps @inesdgomes If we add a link to the search bar, we will need one more Menu Item, and we dont really have that much space on tablet. If we add the Menu Item of the Search bar (icon only), we don't need to use that much space. See the options here

inesdgomes commented 2 weeks ago

Hi @beatrizmartinmartins and @justintemps I think the search option is too hidden, though I also think you did what's possible, Beatriz. The issue here is that the current design for sub-sites nav creates too many limitations and I don't think it'll cover all of our needs. I'm wondering whether we shouldn't completely rethink the nav for subsites? I'll create a separate ticket for this.

Let's put this task on hold for now.

inesdgomes commented 1 week ago

Hi @justintemps As discussed, we'll have another variant of the header for more complex sub-sites, so I think Beatriz's proposal works. Can we sign this off?

@beatrizmartinmartins Please see my comment here: https://www.figma.com/design/RRxsfLNxjoypKrfJg1EwJf?node-id=3979-7043#958928737 Also, let's always say 'Sub-site name' instead of 'Sub-brand'. Thanks

beatrizmartinmartins commented 1 week ago

All design related comments are done. @inesdgomes

inesdgomes commented 1 week ago

Hi @justintemps As discussed, we'll have another variant of the header for more complex sub-sites, so I think Beatriz's proposal works. Can we sign this off?

@beatrizmartinmartins Please see my comment here: https://www.figma.com/design/RRxsfLNxjoypKrfJg1EwJf?node-id=3979-7043#958928737 Also, let's always say 'Sub-site name' instead of 'Sub-brand'. Thanks

Hi @justintemps This is with you for review.