search

international-labour-organization / designsystem

A design system for the International Labour Organization
Apache License 2.0
1 stars 3 forks source link

Padding incorrect in Promo Card #569

Closed justintemps closed 7 months ago

justintemps commented 9 months ago

Check designs.

highlighted_padding_stager

bashlk commented 8 months ago

@justintemps @inesdgomes I checked the paddings within the promo card against the design (https://www.figma.com/file/EIlsB8YqRXKwk7SXj5sOVp/ILO_Components?type=design&node-id=7191-14643&mode=design&t=rPlAc0wKCATdMmxp-4) and they all seem to match.

Screenshot 2023-11-08 at 13 10 15

The strange thing I found is that the element is getting a padding by default which is slightly different from the "standard" version which is marked in wingsuit as the default. I assume that setting the default value in wingsuit with the preview property does not ensure that it is set by default when the component is used outside of storybook.

Screenshot 2023-11-08 at 13 06 25
inesdgomes commented 8 months ago

I think @justintemps may be better suited to help on this one?

justintemps commented 8 months ago

Hey @bashlk good catch, the values used by the standard class should be the defaults. I think we can address this in #674.