search

international-labour-organization / designsystem

A design system for the International Labour Organization
Apache License 2.0
1 stars 3 forks source link

Create designs for different breakpoints #703

Open inesdgomes opened 10 months ago

inesdgomes commented 10 months ago

⚠️ This is a blocker for #544

@beatrizmartinmartins These are breakpoints we're using in the design system:

X small: 320px Small: 414px Medium: 610px Large: 1024px X Large: 1168px XX Large: 1440px

I would say the priority right now is to create designs for the medium breakpoint. I have doubts that the existing designs work for all the other breakpoints. Is this something that you could check as well?

As for wide screens, I'm not sure we're actually going to need them, so we may replace that task with other things. TBC

beatrizmartinmartins commented 10 months ago

I feel like we could shrink the amount of breakpoints we have because from 320 to 414 nothing changes, or at least it shouldn't. The content simply get's bigger. I feel like the best breakpoints should be:

XSmall: 375px (from 0 until 375px) Small: 610px (goes from 376 to 610px) Medium: 1024px (goes from 611px to 1024px) Large: 1440px (goes from 1025px to 1440px) XLarge: 1680px (from 1441px til infinite)

What do you think? @justintemps @inesdgomes

inesdgomes commented 10 months ago

@justintemps Could you have a look at what @beatrizmartinmartins suggested above?

justintemps commented 10 months ago

@inesdgomes and @beatrizmartinmartins we need to investigate what the impact of this would be first.

inesdgomes commented 10 months ago

@beatrizmartinmartins Justin and I spoke about this. He needs some time to investigate the impact of changing the breakpoints and he won't be able to do it this week. We should be able to review this in January, but for the time being we'll need to stick to the breakpoints we have. Is this a blocker for you or are you able to finalize the designs with this info?

beatrizmartinmartins commented 10 months ago

I can work on those no problem! It will take a little bit more time but I will try to finish them before the 15th @inesdgomes