international-labour-organization / designsystem

A design system for the International Labour Organization
Apache License 2.0
1 stars 3 forks source link

Feature cards: support portrait images #926

Open inesdgomes opened 5 months ago

inesdgomes commented 5 months ago

Feature cards need to support portrait images to feature publications' covers.

inesdgomes commented 4 months ago

@beatrizmartinmartins Could we aim for 22 April to have this ready?

beatrizmartinmartins commented 4 months ago

This we would need to talk about during our weekly. I feel like the best approach is to merge the portrait and the other into one. As said during our meeting, users don't really know the difference between one or another. We do because we work with the DS every single day, but it's not so obvious. Also the portrait mode makes the user scroll more which is something that users don't like to do. What do you think @inesdgomes ?

inesdgomes commented 4 months ago

@beatrizmartinmartins Sure, let's talk about it. But just to be clear, this ticket only concerns the feature card component: https://www.figma.com/file/RRxsfLNxjoypKrfJg1EwJf/ILO-Components-Library?type=design&node-id=2705-5239&mode=design&t=Rng0DC6vNix4jPSl-0

As for making changes to the detail card, that would be a separate task. Or are you saying we should merge both? I think it will be tricky to accommodate a description text in the feature card (that's essentially the main difference between the two components). Moreover, it would require quite a big change in the ILO CMS, which we would like to avoid now.

inesdgomes commented 4 months ago

@beatrizmartinmartins Any updates on this one?

beatrizmartinmartins commented 4 months ago

We will need to review it https://www.figma.com/design/RRxsfLNxjoypKrfJg1EwJf/ILO-Components-Library?m=auto&node-id=6407%3A12268&t=CdkvAU58PJfQ0GYU-1

inesdgomes commented 4 months ago

Aimed for 16 May

beatrizmartinmartins commented 4 months ago

Done https://www.figma.com/design/RRxsfLNxjoypKrfJg1EwJf/ILO-Components-Library?m=auto&node-id=6407%3A12268&t=OFTISlZzpapNarRL-1 Template: https://www.figma.com/design/TnVsWy6VobbHzZdbHdx3Rb/ILO-Page-Templates?m=auto&node-id=5083%3A69022&t=sRRyckchF3r0xlVV-1 @inesdgomes

inesdgomes commented 3 months ago

Hi @beatrizmartinmartins I'm not convinced that we should keep the same very wide ratio of the image container when we show covers. I don't think this works in the templates.

Screenshot 2024-05-21 at 12 53 07 Screenshot 2024-05-21 at 12 53 00

Could we try to have a square image container? This will make the amount of empty space look less odd, I think.

beatrizmartinmartins commented 3 months ago

Let's review this together as I'm not fully sure what you mean by that @inesdgomes

beatrizmartinmartins commented 3 months ago

Changes done. Check them here I made the portrait options smaller on the wide format like we talked about @inesdgomes

inesdgomes commented 3 months ago

Hi @beatrizmartinmartins An update here: having shown the designs to my colleagues, they immediately flagged that realistically speaking it'll be very hard to display groups of cards only with portrait images or only landscape images. They want to be able to mix. I think this is getting too complicated. I'm looking at other agencies websites and they seem to have dropped portrait images for cards showcasing publications. Examples: https://www.unhcr.org/what-we-do/reports-and-publications https://www.wipo.int/tech_trends/en/ https://www.undp.org/publications https://www.unicef.org/research-and-reports

So I'm tempted to drop this idea and create guidelines for images that are meant to promote publications on the web. Let's discuss in our next call.