search

internet-computer-protocol / evm-rpc-canister

Interact with EVM blockchains from the Internet Computer.
https://internetcomputer.org/docs/current/developer-docs/multi-chain/ethereum/evm-rpc/overview
Apache License 2.0
63 stars 13 forks source link

refactor: simplify `CheckedAmountOf` #283

Closed gregorydemay closed 1 month ago

gregorydemay commented 1 month ago

Follow-up on #275 to remove all methods on CheckedAmountOf that were not used. Since none of the checked operations are needed, the type was rename to Amount.

rvanasa commented 1 month ago

Ran cargo clippy --fix and cargo fmt and pushed changes for CI.

THLO commented 1 month ago

Looks good to me, thanks! Is there a reason why the PR is still marked as a draft?

gregorydemay commented 1 month ago

Looks good to me, thanks! Is there a reason why the PR is still marked as a draft?

@THLO Sorry that was a mistake on my side, was ready to be reviewed but I forgot to unmark it as draft on Github