internet-equity / netrics

The network measurements scheduling framework
7 stars 3 forks source link

dev measurement may hang interminably #54

Closed jesteria closed 5 months ago

jesteria commented 1 year ago

🐞 Bug Report

The command underlying the dev measurement – nmap -sn … – may hang without end, i.e. without any timeout, without ever returning a result.

Not only does this break this measurement – it also may interfere with measurements requesting that they are run in isolation of other measurements (e.g. speed measurements).

The underlying cause of such a hang is almost certainly environmental and its remediation is out of scope. However, this measurement should apply a timeout to the nmap command invocation, such that the issue is made explicit, and such that this measurement does not interfere with the execution of others.

Steps to Reproduce

On a machine with faulty networkinge.g. a vanilla Docker container – and with Netrics v0.0.1 installed:

netrics debug run dev

Additional Information

In addition to the above remediation, a framework-level default measurement timeout should be considered.

jesteria commented 7 months ago

See: https://github.com/internet-equity/fate/issues/33