kiview
commented
4 years ago Is this ready for review?
Please, please, please give PRs useful titles and descriptions, else it is nearly impossible to know the context and do a good review. Same goes for branch names, they should communicate what the branch is about, no generic names such as moritz-test-branch please.
Here are some aspects that make up a good PR description:
- Include the purpose of this Pull Request. For example:
This is a spike to explore… This simplifies the display of… This fixes handling of… - Consider providing an overview of why the work is taking place (with any relevant links); don’t assume familiarity with the history
- Be explicit about what feedback you want, if any: a quick pair of :eyes: on the code, discussion on the technical approach, critique on design, a review
- Be explicit about when you want feedback, if the Pull Request is work in progress, say so. A prefix of “[WIP]” in the title (or a PR in draft mode) is a simple, common pattern to indicate that state
introduce gui