internet-sicherheit / ethereum-cache-creator

GNU General Public License v3.0
0 stars 0 forks source link

Don't append new output to existing file #30

Closed Mschnuff closed 4 years ago

Mschnuff commented 4 years ago

The current implementation will add a new JSON array object into the existing file, if file already existing. This leads to broken JSON and therefore can't be a desired behavior.

There are two alternatives:

Append to existing JSON array
Use a more complex JSON object as the file root and record each run as a new session
Just override the file

1 sounds wrong and leads to semantically wrong data, so for the sake of simplicity, I'd suggest using solution 3.

kiview commented 4 years ago

Duplicate of #28