search

internet-sicherheit / ethereum-cache-creator

GNU General Public License v3.0
0 stars 0 forks source link

Remove unused code #45

Open ghost opened 4 years ago

ghost commented 4 years ago

There are some classes (and methods in Bloxberg client) that are never used, except in tests, such as HistoricDataExtractor, BlockGroup, BlockAggregator, BlockWithTransactionCombination. Are they created for future purposes or should be removed?

kiview commented 4 years ago

Since we found that aggregation of data during extraction is more or less inferior to extracting raw data and doing aggregation in post-processing, I think it is fine to remove them.

@moekappels WDYT?

Mschnuff commented 4 years ago

remove everything.

Mschnuff commented 4 years ago

corresponding tests and methods too.

kiview commented 4 years ago

@moekappels Please edit a comment instead of writing multiple successive comments in a short time.