search

internet4000 / radio4000

(deprecated) Radio4000 (v1); public media library system, calm, non-intrusive
https://v1.radio4000.com
GNU General Public License v3.0
46 stars 19 forks source link

Keyboard shortcuts conflict in text inputs #284

Open oskarrough opened 6 years ago

oskarrough commented 6 years ago

It's not yet working as it should. player keyboard shortcuts are triggering inside (some) inputs.

https://github.com/internet4000/radio4000/pull/282#issuecomment-444273366 https://github.com/internet4000/radio4000/issues/269

oskarrough commented 6 years ago

Fixed in #285

oskarrough commented 5 years ago

This is still a problem in https://github.com/internet4000/radio4000/pull/298

oskarrough commented 5 years ago

It happens when we use the normal <input>. When we use Ember's {{input}}, the keyboard events don't trigger more than they should.

So… to close this issue we have to make sure that the shortcuts defined in https://github.com/internet4000/radio4000/blob/master/app/mixins/keyboard-shortcuts-global.js DO NOT trigger inside either <input> or {{input}}.