Improve setup configuration (see #36)

internetarchive / archive-pdf-tools

Fast PDF generation and compression. Deals with millions of pages daily.

https://archive-pdf-tools.readthedocs.io/en/latest/

GNU Affero General Public License v3.0

86 stars 13 forks source link

Improve setup configuration (see #36) #38

Closed mara004 closed 2 years ago

mara004 commented 2 years ago

Moved most configuration from setup.py to setup.cfg, but kept some things in setup.py where it makes sense
Changed static requirements to more tolerant >=
Added extras_require option, which means optional dependencies can now be installed using pip3 install .[optional_group_name], in this case pip3 install .[docs]
(Added git ignore rules)

mara004 commented 2 years ago

@MerlijnWajer Any comments?

MerlijnWajer commented 2 years ago

Sorry for the delay in reviewing (very busy month for me), thank you for doing this!

MerlijnWajer commented 2 years ago

Looks like the github actions to build the package failed: https://github.com/internetarchive/archive-pdf-tools/actions/runs/1720375743 (the Cython stuff doesn't get built?)

I can take a look at that tomorrow.

mara004 commented 2 years ago

Sorry about the CI failiure. Building locally worked for me, though. I'll look into it again to see if there's any obvious mistake.

mara004 commented 2 years ago

Hmm, now after a fresh checkout I can reproduce the issue - it says No module named 'optimiser'

mara004 commented 2 years ago

Oh, I think I found the cause. It's extracting the version that causes trouble. I thought the attr: directive was supposed to get the version literally, but apparently it tries to import nevertheless, which fails because of the missing cython modules. I'll make a second PR to fix this.