search

internetarchive / archive-pdf-tools

Fast PDF generation and compression. Deals with millions of pages daily.
https://archive-pdf-tools.readthedocs.io/en/latest/
GNU Affero General Public License v3.0
86 stars 13 forks source link

Missing test suite? #50

Open mara004 opened 2 years ago

mara004 commented 2 years ago

It looks like archive-pdf-tools currently does not have an automated test suite. I know that not all developers like to work this way, but I think providing a test suite can be very advantageous for quality assurance, to make sure the library works equally well on different platforms. It may also be helpful to verify changes for correctness and avoid regressions. pytest is a popular choice as a test framework among open-source Python projects, for instance.

MerlijnWajer commented 2 years ago

Agreed. I'm not much of a TDD guy, but it would be good to have tests. I made some issues for that some time ago: https://github.com/internetarchive/archive-pdf-tools/issues/16 https://github.com/internetarchive/archive-pdf-tools/issues/5

but I haven't used pytest much at all, so I'd love some contributions from others if you/they feel up for it. :)