internetarchive / bookreader

The Internet Archive BookReader
https://openlibrary.org/dev/docs/bookreader
GNU Affero General Public License v3.0
998 stars 419 forks source link

DOMException when attempting to turn pages #1218

Closed Porges closed 1 year ago

Porges commented 1 year ago

Description

What problem are we solving? What does the experience look like today? What are the symptoms? How can one reproduce the problem?

As of today, when attempting to turn pages I get the following exception in Javascript console. Sometimes I can turn one page but it always breaks after that.

DOMException: Failed to execute 'insertBefore' on 'Node': The node before which the new node is to be inserted is not a child of this node.

Evidence / Screenshot (if possible)

Include evidence of the problem or provide a screenshot.

The full stack trace is:

Uncaught (in promise) DOMException: Failed to execute 'insertBefore' on 'Node': The node before which the new node is to be inserted is not a child of this node.
    at ut.value (https://archive.org/includes/build/js/details-bookreader.min.js?v=dbea6a7c:756:1369989)
    at ut.value (https://archive.org/includes/build/js/details-bookreader.min.js?v=dbea6a7c:756:1370083)
    at ut.value (https://archive.org/includes/build/js/details-bookreader.min.js?v=dbea6a7c:756:1370530)
    at ut.value (https://archive.org/includes/build/js/details-bookreader.min.js?v=dbea6a7c:756:1369793)
    at ut.value (https://archive.org/includes/build/js/details-bookreader.min.js?v=dbea6a7c:756:1368876)
    at ut.value (https://archive.org/includes/build/js/details-bookreader.min.js?v=dbea6a7c:756:1370460)
    at ut.value (https://archive.org/includes/build/js/details-bookreader.min.js?v=dbea6a7c:756:1369793)
    at jt (https://archive.org/includes/build/js/details-bookreader.min.js?v=dbea6a7c:756:1374544)
    at xe.value (https://archive.org/includes/build/js/details-bookreader.min.js?v=dbea6a7c:756:1407896)
    at xe.value (https://archive.org/includes/build/js/details-bookreader.min.js?v=dbea6a7c:756:1402059)
    at xe.value (https://archive.org/includes/build/js/details-bookreader.min.js?v=dbea6a7c:756:1401651)
    at xe.<anonymous> (https://archive.org/includes/build/js/details-bookreader.min.js?v=dbea6a7c:756:1401163)
    at Fe (https://archive.org/includes/build/js/details-bookreader.min.js?v=dbea6a7c:756:1388948)
    at Generator.<anonymous> (https://archive.org/includes/build/js/details-bookreader.min.js?v=dbea6a7c:756:1390413)
    at Generator.next (https://archive.org/includes/build/js/details-bookreader.min.js?v=dbea6a7c:756:1389344)
    at w (https://archive.org/includes/build/js/details-bookreader.min.js?v=dbea6a7c:756:1383083)
    at dt (https://archive.org/includes/build/js/details-bookreader.min.js?v=dbea6a7c:756:1401467)

Expectation

What should be happening? What will it look like / how will it behave when fixed?

Context

What operating system? What browser type and version?

Windows 11/Edge Version 115.0.1901.203 (Official build) (64-bit)

Proposal & Constraints

What is the proposed solution / implementation? Is there a precedent of this approach succeeding elsewhere?

Stakeholders

@-tag any stakeholders of this bug

Porges commented 1 year ago

Further information: this only seems to affect the 2-up view.

cdrini commented 1 year ago

Oh that sucks! Hmmm it's working for me correctly in Edge 115 on this book : https://archive.org/details/jalna00dela/page/16/mode/2up?ref=ol .

Are you experiencing this issue for every book on archive.org ? Or only a specific one? Could you provide the link of the books where you do experience it?

Also you're flipping the pages by clicking on the page? Or the buttons in the UI?

Porges commented 1 year ago

@cdrini yes, every book. Both the edges and the buttons have the same result. I'll try to figure out more information today, didn't have time to dig in yesterday.

cdrini commented 1 year ago

Hi @Porges are you still experiencing this issue? If so would you mind if we jumped on a call so I can try to understand why it's happening?

Porges commented 1 year ago

@cdrini just got back from holiday. I cannot reproduce this any more, so whatever it was has gone away. Weird!