Do not try to get a screenshot if status is 4xx, 5xx

internetarchive / brozzler

brozzler - distributed browser-based web crawler

Apache License 2.0

648 stars 96 forks source link

Do not try to get a screenshot if status is 4xx, 5xx #257

Closed vbanos closed 1 year ago

vbanos commented 1 year ago

The screenshot is an additional thing we do when the capture is successful. Why get a screenshot of 4xx/5xx responses? Its just extra system load. We already got the capture for archiving reasons.

galgeek commented 1 year ago

Is it reasonable to use this code only if simpler404 is set?

vbanos commented 1 year ago

@galgeek good point. PR updated. Thanks.