search

internetarchive / dweb-archive

GNU Affero General Public License v3.0
54 stars 16 forks source link

Samples not playing in /cd_ballad-on-third-avenue_ed-hale #181

Open mitra42 opened 4 years ago

mitra42 commented 4 years ago

THis is samples only, but it should play those samples - instead says Video cant play in Isa's viewer. [https://archive.org/details/cd_ballad-on-third-avenue_ed-hale]

(One of https://github.com/internetarchive/dweb-archive/issues/120 )

arnab15 commented 3 years ago

hello sir, I'm new to opensource I'm Familiar with Html, CSS, javascript , Nodejs, ReactJs, MongoDB I want to contribute here how should I start contributing here? I saw a bug on the home page I want to fix that bug but I'm unable to find the codebase where homepage components are present. sir, can you please help me how should I start contributing here.

mitra42 commented 3 years ago

Hi - the components are in the components directory.

This project isn't being actively managed, but I'll be happy to jump in and answer questions.

arnab15 commented 3 years ago

@mitra42 We can manage it . It's also a great project. I'm going to contribute to it if you permit me. I'm very excited about this project.

arnab15 commented 3 years ago

d-archive error

I'm getting errors during installation I tried npm install as well as yarn install also but it's throwing the same error.

mitra42 commented 3 years ago

I always used yarn, didn't test with NPM.

It looks like the @interenetarchive/ia-components package has been upgraded to require bookreader.

There is a dependency on bookreader as well, so I'm not sure why its not finding its peer. Unfortunately at the time I built package.json (and possibly today) the only place to get bookreader was from github - I don't know if its on npm yet, it might be @jbuckner would know if he's reading this.

i.e. replacing that dependency - "@internetarchive/bookreader": "git+https://github.com/internetarchive/bookreader.git", with "@internetarchive/bookreader": "^4.2.2" might work. It might also work with later versions of ia-components.

Sorry I can't give solid answers, its almost a year since I built this last, and it looks like some of the other IA packages have changed and possibly even changed the technologies that they themselves use.

arnab15 commented 3 years ago

how can we fix it?.Is it possible to fix it. @mitra42

mitra42 commented 3 years ago

It should be possible, but that will take some experimentation - I think replacing the dependency (in package.json) as suggested above might work.

arnab15 commented 3 years ago

Thank you sir @mitra42