Online status isn't getting updated correctly

[JesseWeinstein]

When I go offline, the circle doesn't turn red, even the the console shows failing online checks. I'll investigate more.

[mitra42]

• [x] Nav bar is showing "Connecting"
• [ ] None of the UI is going to offline state (e.g. the line About ... People still shows)

[mitra42]

RESEARCH Core function is ReactSupport.transportStatusAndProps This is called from Page.constructor -

[mitra42]

CLEAN UP (after bug fixed)

• [ ] Check that Page.constructor called when navigation happens, its likely only called once, and may need to be in a ComponentDidMountOrUpdate method

[mitra42]

DIAGNOSIS Running with WiFi on - so should show online (its not)

• Breakpoint on Page.jsx on call to transportStatusAndProps is being hit
• Breakpoint in callback isn't
• transportStatusAndProps is running 1st line but not hitting breakpoint after waterfall
• The httpStatus.status test is good, so running the else to check /info and going to the P_GET but doesnt appear to call the cb()
• hard to trace as p_GET has a number of overlapping calls.

[mitra42]

Obscure ! It was triggering a process called "loopguard" which tries to remove queued http fetches when a page switches. This should have resulted in an error, but the error was being discarded in httptools.queuedFetch rather than sent back on the callback.

[mitra42]

Fixed that but now need to

• [x] Catch error appropriately
• [x] Dont trigger a loopguard error either by new NoLoopGuard flag, or explicitly setting req for loopguard or something else
• [x] Maybe get info direct from DwebTransports as it has it already

[mitra42]

Fixed - and pushed to github and npm