search

internetarchive / dweb-mirror

Offline Internet Archive project
https://www-dweb-mirror.dev.archive.org/
GNU Affero General Public License v3.0
256 stars 27 forks source link

Consider Automated Pull Request Merging,Optionally After Sufficient Review #337

Open xloem opened 3 years ago

xloem commented 3 years ago

See https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/automatically-merging-a-pull-request .

This project looks pretty important, so it would be great to make sure there are ways for it to continue on its own when the maintainers are busy.

mitra42 commented 3 years ago

Hi, I'm not sure auto-merge is going to work, partly because currently I'm the only one who has spent a lot of time on the code, so I might catch something otherwise missed, and if I have to review anyway then its just as easy for me to click the "merge" button at the same time.

Even though I'm no longer working on the project, I'm generally pretty available for code-review and merges, though I'm on Australia time.

Glad you are working on it - thanks for catching problems with the installer - which is a bit surprising given that I've had it working on multiple platforms (OSX, Intel, OLIP, IIAB, Rachel), the OSX is pretty cooked - i.e. I've already got stuff installed - but the other platforms are raw out-of-the-box installs.

mitra42 commented 3 years ago

By the way ... if you are testing and in a position to confirm that yarn update or similar gets the newer packages with no problems I could merge the dependabot PR's -