internetarchive / dweb-mirror

Offline Internet Archive project
https://www-dweb-mirror.dev.archive.org/
GNU Affero General Public License v3.0
256 stars 27 forks source link

Problems opening books - specifically 1984-06-computegazette #370

Closed mitra42 closed 1 year ago

mitra42 commented 1 year ago

@vlnn in issue #365 - the specific bug - a bug in the server that responds to Archive's BookReaderJSIA is worked around, but there are other bugs that stop this page opening... Will leave this open as a meta-bug and open specific separate bugs as I work through getting books to work again.

Note ... this is now a volunteer thing for me, so it may take time - feel free to jump in and help.

mitra42 commented 1 year ago

Bug #369 occurs at startup of dweb-mirror

vlnn commented 1 year ago

@mitra42 Understood -- thanks for the investigation and support. Alas JS is not in my stack, so perhaps my help here would be more of burden. Still, if anything related to QA/documentation or really simple fixes will come around, please let me know.

mitra42 commented 1 year ago

Fixed bug #369, but hit a new one with the images bug #372 - next one to tackle. ....

mitra42 commented 1 year ago

This is fixed now - dweb-mirror v0.2.92 sucessfully opens your test case i.e. /details/1984-06-computegazette @vlnn please feel free to open new issues if you find other things that fail - though can't promise speedy fixes.

With the volunteer time I have available, I'm working through about one significant bug every week or two.

vlnn commented 1 year ago

Yes! It totally works now, thank you @mitra42 (sorry, it took some extra time to check due to blackouts here in Kyiv). I also see that some minor issues with icons and small images on the page are also resolved now. Super cool!

CleanShot 2022-12-24 at 16 59 27@2x
holta commented 1 year ago

Heroic work.

Profound thanks @mitra42 and @vlnn :christmas_tree: