search

internetarchive / fatcat-scholar

search interface for scholarly works
https://scholar.archive.org
Other
80 stars 14 forks source link

Upgrade Dynaconf to 3+ #1

Closed rochacbruno closed 4 years ago

rochacbruno commented 4 years ago

In dynaconf 3+ it is no more recommended to use from dynaconf import settings now the recommendation is to create your own instance of the settings object based on Dynaconf class.

rochacbruno commented 4 years ago

NOTE: I am not sure about the changes on Pipfile.lock, feel free to exclude it by updating this PR branch, I am not a pipenv user and I needed to upgrade Dynaconf to 3.1.1 but pipenv upgraded lots of other libraries.

bnewbold commented 4 years ago

@rochacbruno thanks for this! It may be early next week before I have a change to review and merge. I will take care of Pipfile.lock (eg, by updating other dependencies first and rebasing). I am just setting this repo up for contributions, so there is no LICENSE file yet, but it will be AGPL 3+ ("or later"). Can you confirm those license terms are ok?

rochacbruno commented 4 years ago

Hey, I am ok to contribute with any license.

Dynaconf is MIT/X11 and is compatible with being used/linked in a AGPL software.