internetarchive / fatcat-scholar

search interface for scholarly works
https://scholar.archive.org
Other
78 stars 14 forks source link

Find missing imports by avoiding * import #63

Closed cclauss closed 2 years ago

cclauss commented 3 years ago

fatcat_scholar/transform.py and tests/test_transform.py were missing import json tests/test_work_pipeline.py was missing from typing import Any

bnewbold commented 2 years ago

I finally got around to updating the tooling and lint settings for this project, and there are no more "import *" or import errors. I believe all the other changes here have also been resolved.

The next steps for code quality in this repository are to require more annotations (ANN003,ANN101,ANN204) and reduce the long list of disabled pylint checks.