codecov[bot]
commented
1 year ago Codecov Report
Merging #23 (e0422f1) into main (6b6a839) will increase coverage by
3.10%. The diff coverage is100.00%.:exclamation: Current head e0422f1 differs from pull request most recent head 563a895. Consider uploading reports for the commit 563a895 to get more accurate results
@@ Coverage Diff @@
## main #23 +/- ##
==========================================
+ Coverage 82.05% 85.15% +3.10%
==========================================
Files 24 26 +2
Lines 1989 2405 +416
Branches 106 108 +2
==========================================
+ Hits 1632 2048 +416
Misses 345 345
Partials 12 12 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/filter-map-builder.ts | 100.00% <100.00%> (ø) |
|
| src/search-param-url-generator.ts | 100.00% <100.00%> (ø) |
|
| src/search-params.ts | 100.00% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
github-actions[bot]
The PPS accepts a
filter_mapURL parameter that specifies constraints on metadata field values, such as including/excluding certain values or ensuring they are within a given numeric range. This PR adds afiltersparam and related types to the search service so that it can accept and pass along these constraints. This will allow constraints like selected/negative facets and date picker queries to be more cleanly passed to the PPS (rather than the current approach of joining them into the query string itself).This PR also includes several updates to the demo app, both to enable testing multiple filters and to improve readabililty/folding.