internetarchive / iaux-search-service

GNU Affero General Public License v3.0
4 stars 2 forks source link

WEBDEV-5749 Add publicdate and reviewdate fields to item hit model #25

Closed latonv closed 1 year ago

latonv commented 1 year ago

Until recently, the PPS only provided publicdate and reviewdate fields for full-text search hits, not metadata hits. However, these fields are now present on responses for both types of hits.

This PR adds those two fields to the metadata (ItemHit) model to make them readily accessible to clients.

github-actions[bot] commented 1 year ago

PR Preview Action v1.2.0 :---: Preview removed because the pull request was closed. 2023-01-10 03:30 UTC

codecov[bot] commented 1 year ago

Codecov Report

Merging #25 (d1484b6) into main (97fb1ac) will increase coverage by 0.00%. The diff coverage is 85.71%.

@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   85.14%   85.15%           
=======================================
  Files          26       26           
  Lines        2404     2418   +14     
  Branches      108      110    +2     
=======================================
+ Hits         2047     2059   +12     
- Misses        345      347    +2     
  Partials       12       12           
Impacted Files Coverage Δ
src/models/hit-types/item-hit.ts 89.88% <85.71%> (-0.18%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.